Skip to content

fix(mobile): select the correct draft after adding a project - #24269

Merged
juliusmarminge merged 13 commits into
mainfrom
t3/mobile-audit-project-navigation-20261023
Oct 26, 2026
Merged

juliusmarminge merged 13 commits into
mainfrom
t3/mobile-audit-project-navigation-20261023

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Adding a project could select the wrong environment, open a draft before its project reached the client, or redirect a newer screen when an earlier creation finished.

Completion now uses workspace-detail selection once, after project projection, with a guard against an abandoned or replaced originating route. Requested environments survive connection changes and manual choices. The obsolete route-key rewriting and Home-then-draft workaround are removed.

Direct completion also exposed a native stack bug: a mixed pop/push batch started an animated pop and then an animated push. The Screens fork now applies that batch as one atomic stack replacement. Pure pushes and pops are unchanged. This PR updates the bundled tarball to 5.0.0-t3.45; fork source and regression. A new native binary is required; OTA alone cannot deliver this fix.

Validation: vp run check:changed passes. The 14 project-flow tests use real React hooks, the release React Compiler transform, and the actual stack/workspace router. They cover delayed projection, reconnect/manual selection, abandoned/reopened flows, warm-link parameter changes, and a single selection dispatch. The native regression failed on the previous version with two animated operations and passes for both ordinary and empty-detail stack replacement; normal Back and push behavior also pass. React Doctor reports no findings in the changed files.

Fresh iOS 27 simulator verification used the rebuilt native client (fingerprint 0d807cbe43abdb8f19cb3f77f68ceae9f6e3c33a) and this branch's Metro bundle against isolated backend state. PR → Add project → Local folder now transitions directly to the intended draft, with no Home frame in the inspected recording. Normal New Chat → Add project → Local folder also succeeds; Back returns to Chats. Delayed projection and reconnect races are covered by tests. This is simulator correctness evidence, not physical-device or Release performance evidence.

Before: direct selection left the old native PR list visible.
Before: stale native PR list

After: one transition to the intended project draft.
After: correct draft and header

Direct completion recording, replacing the earlier two-transition workaround

Maintainer-directed scope: Julius requested the project-navigation fixes, adaptation to the current workspace stack, simulator verification, and removal of the intermediate Home transition.

Implemented and reviewed with GPT-6.1-sol through the Codex harness.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. pr:needs-julius Needs Julius: route gate, unverifiable surface, or blocked size:L 100-499 changed lines (additions + deletions). takeover t3 automation: takeover vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant