Repository navigation
fix(mobile): select the correct draft after adding a project - #24269
Merged
juliusmarminge merged 13 commits intoOct 26, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a project could select the wrong environment, open a draft before its project reached the client, or redirect a newer screen when an earlier creation finished.
Completion now uses workspace-detail selection once, after project projection, with a guard against an abandoned or replaced originating route. Requested environments survive connection changes and manual choices. The obsolete route-key rewriting and Home-then-draft workaround are removed.
Direct completion also exposed a native stack bug: a mixed pop/push batch started an animated pop and then an animated push. The Screens fork now applies that batch as one atomic stack replacement. Pure pushes and pops are unchanged. This PR updates the bundled tarball to
5.0.0-t3.45; fork source and regression. A new native binary is required; OTA alone cannot deliver this fix.Validation:
vp run check:changedpasses. The 14 project-flow tests use real React hooks, the release React Compiler transform, and the actual stack/workspace router. They cover delayed projection, reconnect/manual selection, abandoned/reopened flows, warm-link parameter changes, and a single selection dispatch. The native regression failed on the previous version with two animated operations and passes for both ordinary and empty-detail stack replacement; normal Back and push behavior also pass. React Doctor reports no findings in the changed files.Fresh iOS 27 simulator verification used the rebuilt native client (fingerprint
0d807cbe43abdb8f19cb3f77f68ceae9f6e3c33a) and this branch's Metro bundle against isolated backend state. PR → Add project → Local folder now transitions directly to the intended draft, with no Home frame in the inspected recording. Normal New Chat → Add project → Local folder also succeeds; Back returns to Chats. Delayed projection and reconnect races are covered by tests. This is simulator correctness evidence, not physical-device or Release performance evidence.Before: direct selection left the old native PR list visible.

After: one transition to the intended project draft.

Direct completion recording, replacing the earlier two-transition workaround
Maintainer-directed scope: Julius requested the project-navigation fixes, adaptation to the current workspace stack, simulator verification, and removal of the intermediate Home transition.
Implemented and reviewed with GPT-6.1-sol through the Codex harness.